Browse Source

fix: ensure ScrollView content actually scrolls in expanded history cards

- Fixed ScrollView configuration to enable proper content scrolling
- Set isFillViewport = false to allow content to exceed container height
- Added proper layout parameters for content container (WRAP_CONTENT height)
- Enabled vertical scroll bar indicators for user feedback
- Restored reasonable 300dp height for scrollable area

Key fixes:
- Content container now uses WRAP_CONTENT height instead of constrained height
- isFillViewport = false allows scrolling when content exceeds 300dp
- isVerticalScrollBarEnabled = true provides scroll feedback
- Content can now properly scroll vertically when Pokemon data is extensive

The expanded Pokemon data sections will now actually scroll when content overflows the 300dp viewing area, making all comprehensive Pokemon information accessible.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
feature/pgh-1-results-display-history
Quildra 5 months ago
parent
commit
e63e86e9d2
  1. 18
      app/src/main/java/com/quillstudios/pokegoalshelper/ui/HistoryAdapter.kt

18
app/src/main/java/com/quillstudios/pokegoalshelper/ui/HistoryAdapter.kt

@ -180,23 +180,25 @@ class HistoryAdapter(
private fun createExpandedContent(context: Context): View
{
return ScrollView(context).apply {
// Calculate max height as 60% of screen height for better scrolling
val displayMetrics = context.resources.displayMetrics
val maxHeight = (displayMetrics.heightPixels * 0.6).toInt()
// Set a reasonable fixed height for the scrollable area
layoutParams = LinearLayout.LayoutParams(
LinearLayout.LayoutParams.MATCH_PARENT,
maxHeight
dpToPx(context, 300) // Fixed height to ensure scrolling works
)
// Enable proper scrolling behavior
isFillViewport = true
// Configure scrolling behavior
isFillViewport = false // Important: false so content can exceed container height
isScrollbarFadingEnabled = false
scrollBarStyle = View.SCROLLBARS_INSIDE_OVERLAY
isVerticalScrollBarEnabled = true
val contentContainer = LinearLayout(context).apply {
orientation = LinearLayout.VERTICAL
setPadding(0, dpToPx(context, 8), 0, dpToPx(context, 16)) // Add bottom padding for scroll
layoutParams = LinearLayout.LayoutParams(
LinearLayout.LayoutParams.MATCH_PARENT,
LinearLayout.LayoutParams.WRAP_CONTENT // Key: wrap content to allow scrolling
)
setPadding(0, dpToPx(context, 8), 0, dpToPx(context, 16))
tag = "expanded_container"
}

Loading…
Cancel
Save